Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve issue #296: Remove httpbin dependency from TestRequestError #297

Merged

Conversation

YukiBobier
Copy link
Contributor

This pull request addresses and resolves issue #296 by removing the dependency on httpbin from the TestRequestError function.

Replace the use of external httpbin service in TestRequestError
with a local HTTP server using the net/http/httptest package.
This change improves test reliability by eliminating the dependency
on an external service.
Copy link
Owner

@sashabaranov sashabaranov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thank you!

@sashabaranov sashabaranov merged commit 24aa200 into sashabaranov:master May 3, 2023
@YukiBobier YukiBobier deleted the remove-httpbin-dependency branch May 5, 2023 01:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants