add optional params for audio api, e.g. prompt #183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merge upstream
Add some optional args for audio api, e.g. Prompt
Codecov Report
@@ Coverage Diff @@
## master #183 +/- ##
==========================================
- Coverage 70.65% 68.86% -1.80%
==========================================
Files 18 18
Lines 535 562 +27
==========================================
+ Hits 378 387 +9
- Misses 121 133 +12
- Partials 36 42 +6
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
thank you for the PR! 🙌🏻 |
sashabaranov
approved these changes
Mar 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found the prompt argument is useful in audio api, so added following optional args from official doc
https://platform.openai.com/docs/api-reference/audio/create :
Prompt string // For translation, it should be in English
Temperature float32
Language string // For translation, just do not use it. It seems "en" works, not confirmed...
btw. I found there already exist a similar pull request from someone else. I added this change in my local env last week, today I've done some test works(for real env), so It's just a coincidence....
It is ok, that just close this pr, I just want the changes merged ASAP~