Run buildifier -lint=fix -warnings=all -r .
#119
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apparently, I had been formatting my BUILD files wrong for the longest time, so I am happy that this tool exists. Also, I am a little wary of the `@rules_cc`/`@rules_java` stuff -- they appear to be referencing external repositories, and I have no such repositories in my WORKSPACE file, but the build seems to work anyway. Furthermore, the corresponding GitHub repositories (https://github.com/bazelbuild/rules_cc and https://github.com/bazelbuild/rules_java) seem half abandoned, and the `rules_cc` README even states that there is no need to use those rules yet. Oh well, as long as the build works, I am happy.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently, I had been formatting my BUILD files wrong for the longest time, so I am happy that this tool exists. Also, I am a little wary of the
@rules_cc/@rules_javastuff -- they appear to be referencing external repositories, and I have no such repositories in my WORKSPACE file, but the build seems to work anyway. Furthermore, thecorresponding GitHub repositories (https://github.com/bazelbuild/rules_cc and
https://github.com/bazelbuild/rules_java) seem half abandoned, and the
rules_ccREADME even states that there is no need to use those rules yet. Oh well, as long as the build works, I am happy.