Skip to content

Remove superflous stubs #179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 28, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion extension.neon
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,6 @@ parameters:
websiteTitle: string
stubFiles:
- stubs/DomainObjectInterface.stub
- stubs/ObjectMonitoringInterface.stub
- stubs/ObjectStorage.stub
- stubs/QueryInterface.stub
- stubs/QueryResultInterface.stub
Expand Down
4 changes: 0 additions & 4 deletions stubs/ObjectMonitoringInterface.stub

This file was deleted.

46 changes: 0 additions & 46 deletions stubs/ObjectStorage.stub
Original file line number Diff line number Diff line change
Expand Up @@ -9,55 +9,9 @@ namespace TYPO3\CMS\Extbase\Persistence;
*/
class ObjectStorage implements \Iterator, \ArrayAccess
{
/**
* @var array<string, ObjectStorageInternal>
*/
protected $storage;

/**
* @param TEntity|string|null $value
* @param mixed $information
*/
public function offsetSet($value, $information);

/**
* @param TEntity|int|string $value
* @return bool
*/
public function offsetExists($value);

/**
* @param TEntity|int|string $value
*/
public function offsetUnset($value);

/**
* @param TEntity|int|string $value
* @return ($value is int ? TEntity|null : mixed)
*/
public function offsetGet($value);

/**
* This is different from the SplObjectStorage as the key in this implementation is the object hash (string).
* @phpstan-ignore-next-line See https://forge.typo3.org/issues/98146
* @return string
*/
// @phpstan-ignore-next-line See https://forge.typo3.org/issues/98146
public function key();

/**
* @return list<TEntity>
*/
public function toArray();

/**
* @return list<TEntity>
*/
public function getArray();

/**
* @param TEntity $object
* @return bool
*/
public function isRelationDirty($object);
}
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,12 @@ public function forceIntegerInRangeWithMinAndMaxValueDefined(int $theInt): void
assertType('int<0, 100>', $forceIntegerInRange);
}

public function forceIntegerInRangeWithFloatAndWithMinAndMaxValueDefined(float $theFloat): void
{
$theFloat = MathUtility::forceIntegerInRange($theFloat, 1, 100);
assertType('int<1, 100>', $theFloat);
}

public function forceIntegerInRangeWithoutMaxValueSpecified(int $theInt): void
{
$forceIntegerInRange = MathUtility::forceIntegerInRange($theInt, 0);
Expand Down