Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change MODE to CERT_MODE in quick start example #20

Merged
merged 2 commits into from
Aug 28, 2020
Merged

Change MODE to CERT_MODE in quick start example #20

merged 2 commits into from
Aug 28, 2020

Conversation

cw789
Copy link
Contributor

@cw789 cw789 commented Aug 28, 2020

OS env var MODE is conflicting with the one set by Elixir (elixir / iex).

OS env var MODE is conflicting with the one set by Elixir (elixir / iex).
@cw789
Copy link
Contributor Author

cw789 commented Aug 28, 2020

By the way. Thanks Saša for this cool library.
I have some ideas but I'm not sure to get the time to contribute right now.

  • Key with ECDSA instead of RSA
  • Challenge via DNS (but not sure if it fits in here)

I'll keep this in my backlog.

@sasa1977 sasa1977 merged commit f007dbb into sasa1977:master Aug 28, 2020
@sasa1977
Copy link
Owner

Thank you for the PR!

Adding support for EC keys would be great, PRs are welcome :-)

When it comes to DNS challenge, I think this might also be feasable, as long as interaction with a particular DNS is left out of scope. In other words, site_encrypt would provide a mock DNS for local dev & tests, while interaction with the real DNS would be the responsibility of the client.

@cw789 cw789 deleted the patch-1 branch August 28, 2020 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants