-
-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
latest requests package switched chardet to charset_normalizer #296
Comments
So requirementslib uses chardet : https://github.com/sarugaku/requirementslib/blob/master/src/requirementslib/models/setup_info.py#L16 but used to get it through request, until the PR @wangsha linked. Can we make https://github.com/sarugaku/requirementslib/blob/master/setup.cfg#L60 |
What I'm wondering is how this issue hasn't been spotted since is a clear import error |
yukihiko-shinoda
added a commit
to yukihiko-shinoda/asyncffmpeg
that referenced
this issue
Aug 16, 2021
mammo0
added a commit
to mammo0/py-simple-factory-pattern
that referenced
this issue
Aug 30, 2021
mammo0
added a commit
to mammo0/py-simple-classproperty
that referenced
this issue
Aug 30, 2021
mammo0
added a commit
to mammo0/py-simple-plugin-loader
that referenced
this issue
Aug 30, 2021
mammo0
added a commit
to mammo0/py-simple-singleton
that referenced
this issue
Aug 30, 2021
bryant-finney
pushed a commit
to Madoshakalaka/pipenv-setup
that referenced
this issue
Nov 6, 2021
* chore: Adds `chardet` as prod dependency Version 4.0.0 has been tested, so no breaking changes from 3.x.x fixes side-effect of `requirementslib` not specifying `chardet` as dep sarugaku/requirementslib#296 is still open User will not need to install `chardet` manually to use this package
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
psf/requests#5797
This PR created breaking changes for python 3.
The text was updated successfully, but these errors were encountered: