Skip to content

Fix edge case from refactor to pydantic #139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 19, 2023
Merged

Fix edge case from refactor to pydantic #139

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
be426c9
Fix edge case from refactor to pydantic -- only search for any python…
matteius May 19, 2023
884b658
Add news fragment.
matteius May 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions news/139.bugfix.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fix edge case from refactor to pydantic -- only search for any python version when a specific version was not requested.
4 changes: 2 additions & 2 deletions src/pythonfinder/models/path.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -462,14 +462,14 @@ def alternate_sub_finder(obj):
found_version = sub_finder(path)
if found_version:
return found_version
if alternate_sub_finder:
if name and not (minor or patch or pre or dev or arch or major):
for path in paths:
found_version = alternate_sub_finder(path)
if found_version:
return found_version

ver = next(iter(self.get_pythons(sub_finder)), None)
if not ver and alternate_sub_finder is not None:
if not ver and name and not (minor or patch or pre or dev or arch or major):
ver = next(iter(self.get_pythons(alternate_sub_finder)), None)

if ver:
Expand Down