Repository navigation
Added apropiate .gitignore, README and some refactoring - #1
Merged
Merged
Conversation
old version, also nonsourcecode
OSX filesystem metadata.. not source.
Owner
|
Thanks for the work. The code dup was indeed rampant :) |
Contributor
Author
|
The IDE added those, I think those are "best practice", not sure. Anyhow! I can remove them and resubmit. :) |
Owner
|
I'd rather. Other on the KSP channel told me it's common for C# but It really disturb me. |
Contributor
Author
|
Taken care of those whitespaces and updated my IDE not to add them again. :) |
Contributor
Author
|
Woops, I still getting used to using github. :p |
sarbian
added a commit
that referenced
this pull request
Nov 25, 2013
Added apropiate .gitignore, README and some refactoring
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was some code duplication, which I restructured away.
The .gitignore is just the boilerplate github c# one.
I activated the issues features on the forked repo. That means that I intend to react to those and maybe fix things if there is a need for it.
I tested the changes, it behaves, as far as i can tell, exactly like the offical released 1.5.