feat(iterator-utilities): add more methods #809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- `all` (alias for `every`) - `any` (alias for `some`) - `collect` (alias for `toArray`) - `collectInto` - `compare` - `compareBy` - `equal` - `equalBy` - `fuse` - `greaterOrEqualThan` (with alias for `ge`) - `greaterThan` (with alias for `gt`) - `inspect` - `intersperse` - `isSorted` - `isSortedBy` - `isSortedByKey` - `lessOrEqualThan` (with alias for `le`) - `lessThan` (with alias for `lt`) - `maxBy` - `maxByKey` - `minBy` - `minByKey` - `notEqual` - `nth` (alias for `at`) - `stepBy` BREAKING CHANGE: `min` now uses a lexicographical comparison by default. Use `minBy` for custom comparisons. BREAKING CHANGE: `max` now uses a lexicographical comparison by default. Use `maxBy` for custom comparisons.
|
vladfrangu
reviewed
Oct 1, 2024
|
|
||
| for (const value0 of toIterableIterator(iterable)) { | ||
| const result1 = iterator1.next(); | ||
| if (result1.done || !callbackFn(value0, result1.value)) return false; |
There was a problem hiding this comment.
Can't we get a fastpath for arrays?
There was a problem hiding this comment.
Quite a lot of things could get a fastpath for arrays, but that'll require adding more code to handle those cases.
That being said, I considered the possibility of having a sizeHint in our iterator, but that's a future thing.
favna
approved these changes
Oct 19, 2024
favna
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the following functions:
all(alias forevery)any(alias forsome)collect(alias fortoArray)collectIntocomparecompareByequalequalByfusegreaterOrEqualThan(with alias forge)greaterThan(with alias forgt)inspectintersperseisSortedisSortedByisSortedByKeylessOrEqualThan(with alias forle)lessThan(with alias forlt)maxBymaxByKeyminByminByKeynotEqualnth(alias forat)stepByminnow uses a lexicographical comparison by default. UseminByfor custom comparisons.maxnow uses a lexicographical comparison by default. UsemaxByfor custom comparisons.