Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(utilities): rename baseVariants to toTitleCaseDiscordJsVariants #754

Merged
merged 3 commits into from
Jun 4, 2024

Conversation

favna
Copy link
Member

@favna favna commented May 28, 2024

This constant is exported after #750 but the name was kind of vague

@favna favna requested review from kyranet and vladfrangu as code owners May 28, 2024 20:56
@favna favna enabled auto-merge (squash) May 28, 2024 20:56
@favna favna self-assigned this May 28, 2024
Copy link

codecov bot commented May 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.79%. Comparing base (56b377f) to head (2bc798e).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #754   +/-   ##
=======================================
  Coverage   55.79%   55.79%           
=======================================
  Files         232      232           
  Lines       18546    18546           
  Branches     1299     1299           
=======================================
  Hits        10348    10348           
  Misses       8193     8193           
  Partials        5        5           
Flag Coverage Δ
18 55.79% <100.00%> (ø)
19 55.79% <100.00%> (ø)
20 55.79% <100.00%> (ø)
21 55.79% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@favna favna changed the title refactor(utilities): cleanup exports refactor: cleanup re-exports for easier scripting May 28, 2024
@favna favna mentioned this pull request May 28, 2024
@Nytelife26
Copy link
Contributor

all of these except the name change of baseVariants will be resolved by #750 anyway, so i would recommend rescoping this to just the name change. other than that, world's easiest lgtm

@favna favna closed this Jun 4, 2024
auto-merge was automatically disabled June 4, 2024 13:59

Pull request was closed

@favna favna reopened this Jun 4, 2024
@favna favna changed the title refactor: cleanup re-exports for easier scripting refactor(utilities): improve name constant Jun 4, 2024
@favna favna changed the title refactor(utilities): improve name constant refactor(utilities): rename baseVariants to toTitleCaseDiscordJsVariants Jun 4, 2024
@favna favna merged commit cd7e6b5 into main Jun 4, 2024
28 checks passed
@favna favna deleted the refactor/cleanup-exports branch June 4, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants