-
-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added string-store #118
Conversation
1b1ed93
to
a3e5cf0
Compare
This comment was marked as resolved.
This comment was marked as resolved.
db89866
to
1680a5b
Compare
4faef40
to
10daf42
Compare
ed9f6c8
to
276e979
Compare
This PR has been rewritten from the ground up, all reviews from the previous implementation are stale. |
276e979
to
b246365
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
3708a7e
to
8c20b66
Compare
8c20b66
to
c95f586
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also needs updating:
.github/labels-yml
-
Is there a way to add a whole object so
new Schema(Id)
is valid somehow? It's a bit weird to be addingObj.key
for every single key IMHO -
Few people will know what all of
int2/4/8/16/32
etc mean, especially those who don't know C-based languages. I count myself among them in fact. Please describe them better.
c95f586
to
e1a9910
Compare
I chose the chainable method since it's a builder in builders, but Zod/Shapeshift-like objects can be done in a follow-up PR, this version is good enough as-is.
That aside, I wrote some more documentation, I hope that explains it. By the way, after landing this PR, I'd like to hold off the v1.0.0 release, I want a first version in so I can work on QoL and details without having them around a massive PR, that way they're easier to review and to iterate. |
df06b58
to
c49a562
Compare
c49a562
to
ea90b5c
Compare
ea90b5c
to
36c3695
Compare
TODO