Upstream parity

[mappum]

There have been some bugfixes in rust-bitcoincore-rpc which have not made it to this crate yet. It seems things would be easier to keep in sync if we just depended on rust-bitcoincore-json, but it was forked to use the sapio-bitcoin types.

@JeremyRubin would you be open to accepting a PR that changes the dependency to rust-bitcoincore-json and the bitcoin types or should I maintain that in a separate fork? Or possibly, both could be supported gated by a cargo feature (although I'm not sure the correct way to do that since features are not meant to be mutually-exclusive).

[JeremyRubin]

I'd take a PR to fix it -- it's not super straighforward to rebase this on the upstream though afaict, since it seems it will take a very different approach to async...

but the patch should do it feature gated.

[mappum]

The bugfixes I care about are just contained to rust-bitcoincore-json, seems easy enough for the PR to just switch that and leave out changes to the client (which can be integrated later).

Do you want to use sapio-bitcoin by default then have the feature replace it with bitcoin, or vice-versa?

[JeremyRubin]

vice-versa might make more sense -- it just needs to be simple to get the things sapio-bitcoin has, like CTV support and schemars support.

[JeremyRubin]

wip for this here #3

[mappum]

I hadn't put enough thought into it to be ready to submit a PR and now I don't even remember what I added, but FWIW I did this in my fork: https://github.com/mappum/rust-bitcoincore-rpc-async/commits/main