Merged
Conversation
use proper comment syntax for copyright and license information in .mdx files
franzheidl
requested review from
ArtieReus,
andypf,
edda and
hgw77
as code owners
…ially uncomment and skip not working event handler test
properly use setup() and waitFor for navigation tests, still skipping
`role` -> `navigationRole` to differentiate from aria role
make sure the wrapping component can supply specific active styles, too.
…se be overwirtten by defaultStyles
…p name only supply the most basic common styles with this component, rely on the wrapping role-specific components to prove the rest
Make Navigation agnostic of the various types of navigations, update tests accordingly.
ArtieReus
approved these changes
May 15, 2024
Collaborator
ArtieReus
left a comment
ArtieReus
left a comment
There was a problem hiding this comment.
lgtm. All tests passsed
ArtieReus
pushed a commit
that referenced
this pull request
Jun 3, 2024
* [ui] add internal Navigation, NavigtaionItem components WIP * [ui] NavigationIem: add stories * [ui] Navigation: add first test * [ui] Navigation: remove unnecessary wrapper div * [ui] NavigationItem: render button or link * [ui] NavigationItem: add wrapperClassName prop, aria-disabled and aria-selected attrs * [ui] Navigation: add aria-disabled attribute * [ui] Navigation: add more tests * [ui] NavigationItem: properly disable link items, too * [ui] Navigation: add className, arbitrary props test * [ui] Navigation: render arbitrary props * [ui] Navigation, -Item: add link stories * [ui] Navigation: add WIP stories * [ui] fix storybook build for now use proper comment syntax for copyright and license information in .mdx files * [ui] Navigation: WIP: determine selected item by key or any relevant item value * [ui] Navigation: stories: add missing keys * [ui] Navigation: add more tests * [ui] Navigation: add more tests for setting the activeItem * [ui] Navigation: add re-rendering tests for activeItem prop * Automatic application of license header * [ui] Navigation: add remaining tests for settign the active item initially uncomment and skip not working event handler test * [ui] Navigation: add skipped test * [ui] Navigation: actually skip test as per prev commit message * [ui] NavigationItem: make sure component renders ok outside of parent context, too * [ui] Navigation, -Item: add navigationItem tests properly use setup() and waitFor for navigation tests, still skipping * Automatic application of license header * [ui] Navigation: add another (skipped) test * [ui] Navigation: fix typo in test description * [ui] Navigation: re-work tests so they work with cross-ontext/-component callbacks * [ui] NavigationItem: Tests. add comment * [ui] NavigationItem: render icon * [ui] NavigationItem: center items (icon etc.) * [ui] Navigation: rename prop for clarity `role` -> `navigationRole` to differentiate from aria role * [ui] NavigationItem: Test: reflect changed prop name in test * [ui] Navigation: don’t use default navigationRole prop * [ui] NavigationItem: accept activeItemStyles prop make sure the wrapping component can supply specific active styles, too. * [ui] SideNavigation, -Item: rework to thin wrappers around Navigation, -Item * [ui] SideNavigationItem: remove obsolete imports * [ui] SideNavigation: pass navigationRole prop to Navigation * [ui] NavigationItem: render combined `[navigationRole]-item-active` class * [ui] TopNavigation, -Item: re-work to wrap Navigation, -Item components * [ui] NavigationItem: allow passing inactive Styles that would otherwise be overwirtten by defaultStyles * [ui] TabNavigation, -Item: re-work to wrap Navigation, -Item * [ui] TabNavigation, -Item: render a class to represent tabStyle * [ui] TabNavigation, -Item: make tests work * [ui] Navigation: add docs * [ui] NavigationItem: remove activeStyles, add docs, fix ariaLabel prop name only supply the most basic common styles with this component, rely on the wrapping role-specific components to prove the rest * [ui] Side-, Tab-, TopNavigationItem: add bold styles for active state * [ui] Navigation: remove `navigationRole` prop Make Navigation agnostic of the various types of navigations, update tests accordingly. * [ui] bump version to 2.14.0 * [ui] TabNavigation. TopNavigation: Update story descriptions --------- Co-authored-by: License Bot <license_bot@github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce neutral
NavigationandNavigationItemcomponents with improved functionality over the various current XYZ-Navigation components.Refactor
SideNavigation,SideNavigationItem,TabNavigation,TabNavigationItem,TopNavigation,TopNavigationItemto be thin wrappers aroundNavigationandNavigationItem, so all of the former rely on the same functionality and internal logic of the latter.