Skip to content

fix None type bug #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 9, 2022
Merged

fix None type bug #20

merged 2 commits into from
Nov 9, 2022

Conversation

rainerleber
Copy link
Collaborator

@rainerleber rainerleber commented Nov 8, 2022

This PR will fix a None type Bug on the output parameter.

@rainerleber rainerleber linked an issue Nov 8, 2022 that may be closed by this pull request
1 task
@codecov-commenter
Copy link

codecov-commenter commented Nov 8, 2022

Codecov Report

Merging #20 (dc97f1b) into dev (bc0cff6) will decrease coverage by 0.09%.
The diff coverage is 33.33%.

@@            Coverage Diff             @@
##              dev      #20      +/-   ##
==========================================
- Coverage   74.90%   74.80%   -0.10%     
==========================================
  Files          23       23              
  Lines        1546     1548       +2     
  Branches      305      294      -11     
==========================================
  Hits         1158     1158              
- Misses        324      325       +1     
- Partials       64       65       +1     
Flag Coverage Δ
sanity 23.50% <0.00%> (-0.05%) ⬇️
units 77.08% <33.33%> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
plugins/modules/sap_control_exec.py 76.54% <33.33%> (-1.94%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@rainerleber rainerleber merged commit 9259b4b into dev Nov 9, 2022
@rainerleber rainerleber deleted the fix/sap_control_exec branch November 9, 2022 08:10
rainerleber added a commit that referenced this pull request Dec 5, 2022
* fix None type bug (#20)

* fix None type bug

* add change log fragment

* placeholder swpm1 fix

* add new tests (#22)

* test

* add ignore, change py version

* fix test

* add changelog, fix before assignment

* fix pyrfc before assignment

* change ignore file 2.15

* Release 1.4.0 commit

* changelog for 1.4.0

Co-authored-by: sean-freeman <sean.freeman@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sap_control_exec: "TypeError: 'NoneType' object is not iterable"
2 participants