feat(revision-wdf): consolidates hana driver implementations - #1
Conversation
| @@ -0,0 +1,8 @@ | |||
|
|
|||
There was a problem hiding this comment.
keep consistent formatting and remove unnecessary blank lines.
There was a problem hiding this comment.
I deliberately mangled the files: added unnecessary lines, multiple delimiters, partially ignored when executing a query. statements right after each other etc. This is to test the robustness of the implementation.
There was a problem hiding this comment.
https://github.com/golang-migrate/migrate#migrate
Database drivers don't assume things or try to correct user input. When in doubt, fail.
| @@ -0,0 +1 @@ | |||
| CREATE ROW TABLE ROLLBACK_TEST (id INTEGER PRIMARY KEY); | |||
There was a problem hiding this comment.
keep consistent formatting
| @@ -0,0 +1,6 @@ | |||
| CREATE ROW TABLE SPLIT_A (id INTEGER PRIMARY KEY);--SPLIT-- | |||
There was a problem hiding this comment.
keep consistent formatting
There was a problem hiding this comment.
see above.
| CREATE ROW TABLE MULTI_C (id INTEGER PRIMARY KEY); | ||
|
|
||
|
|
||
|
|
There was a problem hiding this comment.
missing migration down script.
There was a problem hiding this comment.
In this case the migration down script is not required. Test only tests parsing and if statements are executed as expected not if up and down works. The data will be cleaned up by the Drop function (drops everything within the schema).
| --SPLIT----SPLIT----SPLIT-- | ||
|
|
||
|
|
||
| CREATE ROW TABLE SPLIT_C (id INTEGER PRIMARY KEY) |
There was a problem hiding this comment.
missing migration down script.
There was a problem hiding this comment.
see above.
| @@ -0,0 +1,6 @@ | |||
| CREATE ROW TABLE SPLIT_A (id INTEGER PRIMARY KEY);--SPLIT-- | |||
There was a problem hiding this comment.
delimiter mix is this allowed?
There was a problem hiding this comment.
tests robustness: ; -> should be ignored by execute -> --SPLIT-- should split the statements.
There was a problem hiding this comment.
https://github.com/golang-migrate/migrate#migrate
Database drivers don't assume things or try to correct user input. When in doubt, fail.
2 participants
No description provided.