docs: update CHANGELOG about fixed schema validation

santutu · Jul 19, 2018 · c2acfa4 · c2acfa4
1 parent bef69d5
commit c2acfa4
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -7,6 +7,10 @@
 
 * added option to pass custom context for the decorators
 
+### Fixes
+
+* validating against a schema will validate against that one instead of every registered one
+
 ### 0.9.0 [BREAKING CHANGE]
 
 #### Features

diff --git a/src/metadata/MetadataStorage.ts b/src/metadata/MetadataStorage.ts
@@ -77,7 +77,8 @@ export class MetadataStorage {
 
         // get metadatas for inherited classes
         const inheritedMetadatas = this.validationMetadatas.filter(metadata => {
-              if (typeof metadata.target === "string")
+            // if target is a string it's means we validate agains a schema, and there is no inheritance support for schemas
+            if (typeof metadata.target === "string")
                 return false;
             if (metadata.target === targetConstructor)
                 return false;