Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix reading mapping > 5 causes crc 0x0000000 #924

Merged
merged 1 commit into from
Apr 15, 2024
Merged

fix reading mapping > 5 causes crc 0x0000000 #924

merged 1 commit into from
Apr 15, 2024

Conversation

smesgr9000
Copy link
Collaborator

With my hw5 I have an issue dumping C64 carts with mappings of 6 or higher resulting in message "crc 0x0000000" with an empty file on sd card. I think the controller has an issue with declaring a variable inside the case statement but without its own scope. Afaik this should be solved by the compiler or result into an error at compiler stage. With the additional scoping the code works fine for me.

@PsyK0p4T PsyK0p4T closed this Apr 15, 2024
@PsyK0p4T PsyK0p4T reopened this Apr 15, 2024
@PsyK0p4T PsyK0p4T merged commit 017da53 into sanni:master Apr 15, 2024
10 checks passed
@smesgr9000 smesgr9000 deleted the c64fix branch April 24, 2024 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants