Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency moment to v2.29.4 [SECURITY] #56

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Apr 24, 2022

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
moment (source) 2.24.0 -> 2.29.4 age adoption passing confidence

GitHub Vulnerability Alerts

CVE-2022-24785

Impact

This vulnerability impacts npm (server) users of moment.js, especially if user provided locale string, eg fr is directly used to switch moment locale.

Patches

This problem is patched in 2.29.2, and the patch can be applied to all affected versions (from 1.0.1 up until 2.29.1, inclusive).

Workarounds

Sanitize user-provided locale name before passing it to moment.js.

References

Are there any links users can visit to find out more?

For more information

If you have any questions or comments about this advisory:

CVE-2022-31129

Impact

  • using string-to-date parsing in moment (more specifically rfc2822 parsing, which is tried by default) has quadratic (N^2) complexity on specific inputs
  • noticeable slowdown is observed with inputs above 10k characters
  • users who pass user-provided strings without sanity length checks to moment constructor are vulnerable to (Re)DoS attacks

Patches

The problem is patched in 2.29.4, the patch can be applied to all affected versions with minimal tweaking.

Workarounds

In general, given the proliferation of ReDoS attacks, it makes sense to limit the length of the user input to something sane, like 200 characters or less. I haven't seen legitimate cases of date-time strings longer than that, so all moment users who do pass a user-originating string to constructor are encouraged to apply such a rudimentary filter, that would help with this but also most future ReDoS vulnerabilities.

References

There is an excellent writeup of the issue here: https://github.com/moment/moment/pull/6015#issuecomment-1152961973=

Details

The issue is rooted in the code that removes legacy comments (stuff inside parenthesis) from strings during rfc2822 parsing. moment("(".repeat(500000)) will take a few minutes to process, which is unacceptable.


Release Notes

moment/moment (moment)

v2.29.4

Compare Source

  • Release Jul 6, 2022
    • #​6015 [bugfix] Fix ReDoS in preprocessRFC2822 regex

v2.29.3

Compare Source

  • Release Apr 17, 2022

v2.29.2

Compare Source

  • Release Apr 3 2022

Address GHSA-8hfj-j24r-96c4

v2.29.1

Compare Source

  • Release Oct 6, 2020

Updated deprecation message, bugfix in hi locale

v2.29.0

Compare Source

  • Release Sept 22, 2020

New locales (es-mx, bn-bd).
Minor bugfixes and locale improvements.
More tests.
Moment is in maintenance mode. Read more at this link:
https://momentjs.com/docs/#/-project-status/

v2.28.0

Compare Source

  • Release Sept 13, 2020

Fix bug where .format() modifies original instance, and locale updates

v2.27.0

Compare Source

  • Release June 18, 2020

Added Turkmen locale, other locale improvements, slight TypeScript fixes

v2.26.0

Compare Source

  • Release May 19, 2020

TypeScript fixes and many locale improvements

v2.25.3

Compare Source

  • Release May 4, 2020

Remove package.json module property. It looks like webpack behaves differently
for modules loaded via module vs jsnext:main.

v2.25.2

Compare Source

  • Release May 4, 2020

This release includes ES Module bundled moment, separate from it's source code
under dist/ folder. This might alleviate issues with finding the `./locale
subfolder for loading locales. This might also mean now webpack will bundle all
locales automatically, unless told otherwise.

v2.25.1

Compare Source

  • Release May 1, 2020

This is a quick patch release to address some of the issues raised after
releasing 2.25.0.

  • 2e268635 [misc] Revert #​5269 due to webpack warning
  • 226799e1 [locale] fil: Fix metadata comment
  • a83a521 [bugfix] Fix typeoff usages
  • e324334 [pkg] Add ts3.1-typings in npm package
  • 28cc23e [misc] Remove deleted generated locale en-SG

v2.25.0

Compare Source

  • Release May 1, 2020

  • #​4611 022dc038 [feature] Support for strict string parsing, fixes #​2469

  • #​4599 4b615b9d [feature] Add support for eras in en and jp

  • #​4296 757d4ff8 [feature] Accept custom relative thresholds in duration.humanize

  • 18 bigfixes

  • 36 locale fixes

  • 5 new locales (oc-lnc, zh-mo, en-in, gom-deva, fil)


Configuration

📅 Schedule: Branch creation - "" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate bot changed the title Update dependency moment to v2.29.2 [SECURITY] Update dependency moment to v2.29.2 [SECURITY] - autoclosed Jun 20, 2022
@renovate renovate bot closed this Jun 20, 2022
@renovate renovate bot deleted the renovate/npm-moment-vulnerability branch June 20, 2022 16:29
@renovate renovate bot changed the title Update dependency moment to v2.29.2 [SECURITY] - autoclosed Update dependency moment to v2.29.2 [SECURITY] Jun 20, 2022
@renovate renovate bot restored the renovate/npm-moment-vulnerability branch June 20, 2022 20:14
@renovate renovate bot reopened this Jun 20, 2022
@renovate renovate bot changed the title Update dependency moment to v2.29.2 [SECURITY] Update dependency moment to 2.29.2 [SECURITY] Jun 20, 2022
@renovate renovate bot force-pushed the renovate/npm-moment-vulnerability branch from 781fb2f to 30f38fa Compare November 20, 2022 13:35
@renovate renovate bot changed the title Update dependency moment to 2.29.2 [SECURITY] Update dependency moment to 2.29.4 [SECURITY] Nov 20, 2022
@renovate renovate bot changed the title Update dependency moment to 2.29.4 [SECURITY] Update dependency moment to v2.29.4 [SECURITY] Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants