Skip to content

feat: add experimental new live events API #797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 7, 2024
Merged

feat: add experimental new live events API #797

merged 3 commits into from
May 7, 2024

Conversation

stipsan
Copy link
Member

@stipsan stipsan commented May 7, 2024

This new feature is highly experimental, and is intentionally not documented yet (it might change, and for now we need to test our assumptions).
All relevant surfaces are marked with @alpha and a message clearly signaling that it's an experimental feature.
It also requires apiVersion: 'vX' at the moment.

@stipsan stipsan marked this pull request as ready for review May 7, 2024 15:38
@stipsan stipsan enabled auto-merge (squash) May 7, 2024 15:40
@stipsan stipsan disabled auto-merge May 7, 2024 15:56
@stipsan stipsan enabled auto-merge (squash) May 7, 2024 15:58
jonabc
jonabc previously approved these changes May 7, 2024
Copy link

@jonabc jonabc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few nits, nothing blocking for an initial version. Looks good :shipit: !

atombender
atombender previously approved these changes May 7, 2024
Copy link
Member

@atombender atombender left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@stipsan stipsan dismissed stale reviews from atombender and jonabc via 2e1c2bb May 7, 2024 16:30
@stipsan stipsan merged commit de0cec7 into main May 7, 2024
@stipsan stipsan deleted the cldx-2062 branch May 7, 2024 16:35
@squiggler squiggler bot mentioned this pull request May 7, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants