fix(types): disambiguate SanityClient
imports
#445
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the JS world these two are the same instance:
But due to how we generate typings, TypeScript thinks they're not compatible as they're classes with private properties:
But now it'll throw an error like:
Errors are usually not as clear as the above btw, it took me a while to figure out what was wrong when I first encountered this. The fix is not obvious:
So the point of this PR is that if you now do this:
You'll get a clear error:
And the import uses a
@deprecated
symbol to make sure VS Code don't autocomplete it, and clearly highlights it: