invariant: body after request is processed must be binary #662
+1
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seemethere
approved these changes
Apr 25, 2017
|
I don't have a milestone to group this with but I will merge once I do. |
r0fls
reviewed
Apr 25, 2017
| @@ -173,8 +173,7 @@ def on_body(self, body): | |||
| self.request.body.append(body) | |||
|
|
|||
| def on_message_complete(self): | |||
| if self.request.body: | |||
| self.request.body = b''.join(self.request.body) | |||
| self.request.body = b''.join(self.request.body) | |||
There was a problem hiding this comment.
This will fail if the request body is None. Does that ever happen?
There was a problem hiding this comment.
No originally self.request.body instantiates itself as a list
r0fls
approved these changes
Apr 25, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Body must be of type bytes after request is processed, even if there is no data.
If not, code will fail for example in here if the request does not have any parameters in the body but the content-type is application/x-www-form-urlencoded