Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup: Find packages #2049

Merged
merged 1 commit into from
Mar 7, 2021
Merged

Setup: Find packages #2049

merged 1 commit into from
Mar 7, 2021

Conversation

el1s7
Copy link
Contributor

@el1s7 el1s7 commented Mar 7, 2021

Error when installing from master because some packages ('models' & 'mixins') are not being included.
When installing master like this pip3 install git+https://github.com/sanic-org/sanic

Error when installing from master because some packages ('models' & 'mixins') are not being included.
@codecov
Copy link

codecov bot commented Mar 7, 2021

Codecov Report

Merging #2049 (315c578) into master (2c25af8) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #2049   +/-   ##
=========================================
  Coverage   91.981%   91.981%           
=========================================
  Files           36        36           
  Lines         3292      3292           
  Branches       559       559           
=========================================
  Hits          3028      3028           
  Misses         179       179           
  Partials        85        85           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c25af8...315c578. Read the comment docs.

@ahopkins ahopkins merged commit 5c624f8 into sanic-org:master Mar 7, 2021
@ahopkins
Copy link
Member

ahopkins commented Mar 7, 2021

Nice catch, thanks for the PR.

el1s7 added a commit to el1s7/sanic that referenced this pull request Mar 8, 2021
Error when installing from master because some packages ('models' & 'mixins') are not being included.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants