-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update asgi.py replace the latin-1 with utf-8. #1837
update asgi.py replace the latin-1 with utf-8. #1837
Conversation
for avoid another unicode warn or error,please use utf-8.Thanks! latin-1 with utf-8 difference.:https://stackoverflow.com/questions/7048745/what-is-the-difference-between-utf-8-and-iso-8859-1/39109074
Codecov Report
@@ Coverage Diff @@
## master #1837 +/- ##
==========================================
- Coverage 92.06% 91.97% -0.10%
==========================================
Files 27 27
Lines 3089 3089
Branches 552 552
==========================================
- Hits 2844 2841 -3
- Misses 171 173 +2
- Partials 74 75 +1
Continue to review full report at Codecov.
|
Yes, the url_bytes = b"%b?%b" % (scope["raw_path"], scope["query_string"]) I believe that |
I'll do another survey of other implementations and the spec. But I believe that is correct. |
@SchopenhauerZhang could you implement and test this change, so that we could get this merged? |
Ping @SchopenhauerZhang |
I agree with @Tronic here. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If this is incorrect, please respond with an update. Thank you for your contributions. |
I am closing this. If someone thinks there is something we still need here, please reopen a new PR. |
for avoid another unicode warn or error,please use utf-8.Thanks!
latin-1 with utf-8 difference.:https://stackoverflow.com/questions/7048745/what-is-the-difference-between-utf-8-and-iso-8859-1/39109074