Fixes #103 #104
Closed
Fixes #103 #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
June 6, 2019 13:03
chenjr0719
requested changes
Jun 8, 2019
added 3 commits
June 9, 2019 10:52
…same as the current github python template)
|
I've made all the requested changes except using the full qualified name as the object name by default. |
chenjr0719
previously approved these changes
Jun 9, 2019
There was a problem hiding this comment.
@volfpeter Thanks, for your contributions. @ahopkins I think this PR is ready to go.
|
Thank's a lot! That was smooth! :) |
…ecorator class, refs #107
|
Sorry, i shouldn't have pushed my changes. It was stupid. Should i reverse my commit to make this PR pass first? |
|
Yes, please. |
ahopkins
requested changes
Jun 10, 2019
|
I've submitted another PR (#110) instead where I've fixed my own git history and resolved merge conflicts as well. Please close this PR and merge that one instead. Sorry for the issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objectinstance registration indefinitions..gitignore.Pipfileto make installation testing easier for pipenv users.