Skip to content

Conversation

@BenTopping
Copy link
Contributor

Updates Useq_wafer column comments to NPG suggestions - see below.

Changes proposed in this pull request

  • Update entity_type column comment

    • "I doubt we will ever have a non-indexed library. Out of four types we have for Illumina, library, library_control, library_indexed, library_indexed_spike, only library_indexed applies to UG. This column might ve redundant, but it might be prudent to keep it in case we have to expand the range. Suggested comment 'Entity type, eg library_indexed or in future some other library type"
  • Update entity_id_lims comment

    • "UG seems to have their own internal controls. At the moment we do not not add spiked-in PhiX. Might be better to change the comment to 'Most specific LIMs identifier associated with this library"

@codecov
Copy link

codecov bot commented Nov 27, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.00%. Comparing base (c41d37e) to head (3bd473f).
⚠️ Report is 2 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #853   +/-   ##
========================================
  Coverage    98.00%   98.00%           
========================================
  Files           78       78           
  Lines         1755     1755           
========================================
  Hits          1720     1720           
  Misses          35       35           
Flag Coverage Δ
pull_request 98.00% <ø> (ø)
push 98.00% <ø> (ø)
ruby 98.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@BenTopping BenTopping merged commit d4fe03b into develop Nov 27, 2025
6 checks passed
@BenTopping BenTopping deleted the update-useq-wafer-comments branch November 27, 2025 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants