Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch 1.3.1 #128

Merged
merged 21 commits into from
Sep 25, 2024
Merged

Patch 1.3.1 #128

merged 21 commits into from
Sep 25, 2024

Conversation

tkchafin
Copy link
Contributor

@tkchafin tkchafin commented Sep 24, 2024

  • Fix for HiC CRAM inputs since 1.1.0
  • For for PacBio FASTQ inputs since 1.3.0
  • Correct the license

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@tkchafin
Copy link
Contributor Author

Not sure what the EditorConfig fail is

@tkchafin
Copy link
Contributor Author

editorconfig-checker is passing locally

@tkchafin
Copy link
Contributor Author

editorconfig-checker is some issue introduced in the latest update, fixing to prior version resolves the issue. I think should be ready to review now.

Copy link
Contributor

@reichan1998 reichan1998 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you! It's working well.

Copy link
Member

@muffato muffato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • In this pipeline we also keep track of the citations in CITATIONS.md. Can you add bbtools there ?

CHANGELOG.md Outdated Show resolved Hide resolved
conf/base.config Outdated Show resolved Hide resolved
@tkchafin tkchafin merged commit 4751ca5 into main Sep 25, 2024
7 of 8 checks passed
@tkchafin tkchafin deleted the patch branch September 25, 2024 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants