Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable BWAMEM2 index when no short reads data #100

Merged
merged 2 commits into from
Aug 1, 2024

Conversation

reichan1998
Copy link
Contributor

Fixes #65

  • Add a function to check datatypes ( illumina or hic) from the samplesheet (params.input)

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@tkchafin
Copy link
Contributor

@reichan1998 sorry for the delay, I will get to this by the end of the week, just super busy at the moment!

@tkchafin tkchafin self-requested a review July 29, 2024 16:49
@reichan1998 reichan1998 linked an issue Jul 30, 2024 that may be closed by this pull request
@tkchafin tkchafin changed the base branch from dev to bwamem_index August 1, 2024 14:13
@tkchafin
Copy link
Contributor

tkchafin commented Aug 1, 2024

Merging this into a separate branch for now as I realise that the implementation will change a bit after merging nf_validation

@tkchafin tkchafin merged commit 10c4705 into sanger-tol:bwamem_index Aug 1, 2024
6 checks passed
@reichan1998 reichan1998 deleted the disable-bwamem2_index branch August 16, 2024 11:10
@tkchafin tkchafin mentioned this pull request Aug 20, 2024
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disable BWAMEM2_INDEX when no short read data
2 participants