Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make zone properties public #75

Merged
merged 2 commits into from
Dec 1, 2023
Merged

Make zone properties public #75

merged 2 commits into from
Dec 1, 2023

Conversation

marcvdm
Copy link
Contributor

@marcvdm marcvdm commented Oct 24, 2023

The only way to access the properties is to call toArray on the object.

I also made the service read only because this is validated so it should not change on the object.

@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (834a68e) 98.77% compared to head (bf4fd7f) 98.77%.

❗ Current head bf4fd7f differs from pull request most recent head 7709a0b. Consider uploading reports for the commit 7709a0b to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##             master      #75   +/-   ##
=========================================
  Coverage     98.77%   98.77%           
  Complexity      588      588           
=========================================
  Files           111      111           
  Lines          2295     2295           
=========================================
  Hits           2267     2267           
  Misses           28       28           
Files Coverage Δ
src/Domain/Zone.php 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@A1rPun A1rPun merged commit a400256 into sandwave-io:master Dec 1, 2023
1 check passed
@marcvdm marcvdm deleted the fix/zone branch January 10, 2024 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants