Skip to content

Conversation

@dwrensha
Copy link
Contributor

@dwrensha dwrensha commented Jun 3, 2016

This is, of course, dependent on the new flow actually landing in the main Sandstorm repo.

Note that tokens returned from SandstormApi.save() are binary. Since this app stuffs the tokens into JSON, we need to choose an encoding. I've chosen url-safe base64 here.

@zarvox
Copy link
Collaborator

zarvox commented Jun 6, 2016

I tested this out in conjuction with the change at sandstorm-io/sandstorm#2027 and the Python-side changes look perfectly reasonable. I've built a package (with this patch and an spk version bump):

HOWEVER.

I believe there may be a regression in the Sandstorm-side changeset, because under this pair of branches, the following workflow fails for me:

  1. Alice creates Hacker Slides (or any other app) grain
  2. Alice creates test app grain
  3. Alice clicks "request UiView" button and completes the request with the grain from step 1.
  4. Alice shares the test app grain with Bob via a link.
  5. Bob opens the sharing link as his Bob identity.
  6. Bob clicks the "Offer" button.
  7. Bob should be able to see the grain from step 1.

Instead, Bob consistently sees "You do not have permission to access this grain."

With sandstorm-165 and test-9.spk, this workflow works as expected.

@zarvox
Copy link
Collaborator

zarvox commented Jun 6, 2016

I confirm that sandstorm-io/sandstorm#2034 fixes the "can't access the grain" problem. Thanks!

A new issue has appeared, which is that if you rename the Hacker Slides grain between step 1 and step 2, then when bob views the grain in step 7, the grain title appears to be "New HackerSlides grain title (was: Untitled Test App test page)". Something going weird in the title-denormalizing code? Probably a bug to be fixed in sandstorm-io/sandstorm#2027.

@zarvox zarvox merged commit bbbc0d7 into sandstorm-io:master Jul 2, 2016
@dwrensha dwrensha deleted the claim-request branch July 2, 2016 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants