Skip to content

Commit

Permalink
[c10d] Comment out ddp_hook_with_optimizer_parity tests (pytorch#100215)
Browse files Browse the repository at this point in the history
This is a mirror PR of D45339293

Summary:
These tests cause the following errors internally with unknown reason:
```
AttributeError: type object 'TestDistBackendWithSpawn' has no attribute 'test_ddp_hook_with_optimizer_parity_adam'
AttributeError: type object 'TestDistBackendWithSpawn' has no attribute 'test_ddp_hook_with_optimizer_parity_adamw'
AttributeError: type object 'TestDistBackendWithSpawn' has no attribute 'test_ddp_hook_with_optimizer_parity_sgd'
```
Commenting these tests out to unblock other PRs.

Test Plan: Sandcastle

Pull Request resolved: pytorch#100215
Approved by: https://github.com/wz337, https://github.com/fduwjj
  • Loading branch information
kwen2501 authored and pytorchmergebot committed Apr 28, 2023
1 parent efed5e1 commit 628a8df
Showing 1 changed file with 8 additions and 1 deletion.
9 changes: 8 additions & 1 deletion torch/testing/_internal/distributed/distributed_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,6 @@
IS_FBCODE,
NO_MULTIPROCESSING_SPAWN,
IS_SANDCASTLE,
parametrize,
skip_but_pass_in_sandcastle,
skip_but_pass_in_sandcastle_if,
)
Expand Down Expand Up @@ -4905,6 +4904,13 @@ def _test_ddp_hook_with_optimizer_parity(
)
dist.barrier()

"""
# Commenting out the following 3 tests as they cause Sandcastle jobs to fail
# Failure signature:
# AttributeError: type object 'TestDistBackendWithSpawn' has no attribute 'test_ddp_hook_with_optimizer_parity_adamw
from torch.testing._internal.common_utils import parametrize
@skip_but_pass_in_sandcastle_if(
BACKEND == "nccl" or BACKEND == "ucc",
"Issues with async error handling, see https://github.com/pytorch/pytorch/issues/73259",
Expand Down Expand Up @@ -4973,6 +4979,7 @@ def test_ddp_hook_with_optimizer_parity_sgd(self, optimize_subset):
momentum=sgd_momentum,
weight_decay=sgd_weight_decay,
)
"""

@skip_if_lt_x_gpu(2)
def test_get_data_parallel_params(self):
Expand Down

0 comments on commit 628a8df

Please sign in to comment.