Skip to content

Commit

Permalink
module names are made more consistent with POI page (pytorch#83219)
Browse files Browse the repository at this point in the history
Less intrusive update after the first attempt got reverted: pytorch#83127

fix for: pytorch#83363
Pull Request resolved: pytorch#83219
Approved by: https://github.com/malfet
  • Loading branch information
b0noI authored and pytorchmergebot committed Aug 16, 2022
1 parent 92a0058 commit 2c79b9c
Show file tree
Hide file tree
Showing 4 changed files with 56 additions and 25 deletions.
53 changes: 40 additions & 13 deletions .github/merge_rules.json
Original file line number Diff line number Diff line change
@@ -1,4 +1,14 @@
[
{
"name": "Core Maintainers",
"patterns": ["*"],
"approved_by": ["soumith", "gchanan", "ezyang", "dzhulgakov"],
"mandatory_checks_name": [
"Facebook CLA Check",
"Lint",
"pull"
]
},
{
"name": "ONNX exporter",
"patterns": [
Expand Down Expand Up @@ -33,7 +43,7 @@
"torch/csrc/jit/codegen/cuda/**",
"benchmarks/cpp/nvfuser/**"
],
"approved_by": ["csarofeen", "ngimel", "jjsjann123"],
"approved_by": ["csarofeen", "ngimel", "jjsjann123", "ptrblck"],
"mandatory_checks_name": [
"Facebook CLA Check",
"Lint",
Expand All @@ -42,31 +52,37 @@
},
{
"name": "OSS CI",
"patterns": [".github/**", ".circleci/**", ".jenkins/**", "scripts/**", "tools/**"],
"approved_by": ["ezyang", "pytorch/pytorch-dev-infra"],
"patterns": [
".github/**",
".circleci/**",
".jenkins/**",
"scripts/**",
"tools/**"
],
"approved_by": ["alband", "dagitses", "pytorch/pytorch-dev-infra"],
"mandatory_checks_name": [
"Facebook CLA Check",
"Lint",
"pull"
]
},
{
"name": "CI Pinned Hashes",
"name": "OSS CI / pytorchbot",
"patterns": [
".github/ci_commit_pins/vision.txt",
".github/ci_commit_pins/torchdynamo.txt"
],
"approved_by": ["pytorchbot", "ezyang", "pytorch/pytorch-dev-infra"],
"approved_by": ["pytorchbot"],
"mandatory_checks_name": [
"Facebook CLA Check",
"Lint",
"pull"
]
},
{
"name": "XLA hash pin update",
"name": "OSS CI / pytorchbot / XLA",
"patterns": [".github/ci_commit_pins/xla.txt"],
"approved_by": ["pytorchbot", "ezyang", "pytorch/pytorch-dev-infra"],
"approved_by": ["pytorchbot"],
"mandatory_checks_name": [
"Facebook CLA Check",
"Lint",
Expand All @@ -77,7 +93,7 @@
{
"name": "Documentation",
"patterns": ["docs/**", "torch/*docs.py"],
"approved_by": ["mruberry", "ngimel", "janeyx99", "svekars"],
"approved_by": ["svekars"],
"mandatory_checks_name": [
"Facebook CLA Check",
"Lint",
Expand All @@ -87,7 +103,7 @@
{
"name": "Mobile",
"patterns": ["ios/**", "android/**", "test/mobile/**"],
"approved_by": ["linbinyu", "kit1980", "IvanKobzarev", "dreiss"],
"approved_by": ["linbinyu", "IvanKobzarev", "dreiss", "raziel"],
"mandatory_checks_name": [
"Facebook CLA Check",
"Lint",
Expand All @@ -108,7 +124,7 @@
"tools/autograd/templates/python_linalg_functions.cpp",
"test/test_linalg.py"
],
"approved_by": ["nikitaved", "mruberry", "pearu", "Lezcano", "IvanYashchuk"],
"approved_by": ["mruberry", "Lezcano", "IvanYashchuk"],
"mandatory_checks_name": [
"Facebook CLA Check",
"Lint",
Expand Down Expand Up @@ -170,7 +186,7 @@
"aten/src/ATen/mps/**",
"aten/src/ATen/native/mps/**"
],
"approved_by": ["kulinseth", "razarmehr"],
"approved_by": ["kulinseth", "alband", "malfet", "razarmehr"],
"mandatory_checks_name": [
"Facebook CLA Check",
"Lint",
Expand All @@ -183,7 +199,7 @@
"torch/distributions/**",
"test/distributions/**"
],
"approved_by": ["fritzo", "neerajprad", "alicanb", "vishwakftw"],
"approved_by": ["fritzo", "neerajprad", "alicanb"],
"mandatory_checks_name": [
"Facebook CLA Check",
"Lint",
Expand All @@ -210,7 +226,18 @@
"test/cpp/dist_autograd/**",
"test/cpp/rpc/**"
],
"approved_by": ["mrshenli", "pritamdamania87", "d4l3k", "kiukchung", "pietern"],
"approved_by": [
"mrshenli",
"pritamdamania87",
"zhaojuanmao",
"rohan-varma",
"wanchaol",
"fduwjj",
"H-Huang",
"d4l3k",
"aazzolini",
"kwen2501"
],
"mandatory_checks_name": [
"Facebook CLA Check",
"Lint",
Expand Down
5 changes: 5 additions & 0 deletions CODEOWNERS
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
# IMPORTANT:
# This file is ONLY used to subscribe for the notifications for a
# PRs related to a specific files. People in this file are
# notrequire the approval for your changes.

# This is a comment.
# Each line is a file pattern followed by one or more owners.
# For module labels => owners mapping, please see https://github.com/pytorch/pytorch/issues/24422.
Expand Down
10 changes: 0 additions & 10 deletions docs/source/community/governance.rst
Original file line number Diff line number Diff line change
Expand Up @@ -60,16 +60,6 @@ design docs, any disputes and dispute resolutions) so that
contributors and other interested parties understand the
future direction of the project and can participate in discussion.

Within `pytorch/pytorch <https://github.com/pytorch/pytorch>`__,
maintainer groups are defined in the
`CODEOWNERS <https://github.com/pytorch/pytorch/blob/master/CODEOWNERS>`__
file in the GitHub repository. For other modules that correspond
to repositories, membership is recorded on GitHub as access
level to the repo (i.e. “write” permission). Module maintainers
are given privileges to administrate the repository (except for
`pytorch/pytorch <https://github.com/pytorch/pytorch>`__ where
they are responsible for a folder).

Responsibilities of the maintainer includes:
* Triaging high priority issues of the module
* Triaging and reviewing and landing high priority pull requests of the module
Expand Down
13 changes: 11 additions & 2 deletions docs/source/community/persons_of_interest.rst
Original file line number Diff line number Diff line change
Expand Up @@ -128,6 +128,14 @@ NVIDIA / CUDA
- Piotr Bialecki (`ptrblck <https://github.com/ptrblck>`__)
- (emeritus) Xiaoqiang Zheng (`zheng-xq <https://github.com/zheng-xq>`__)

NVFuser
~~~~~~~

- Christian Sarofeen (`csarofeen <https://github.com/csarofeen>`__)
- Alex Jann (`jjsjann123 <https://github.com/jjsjann123>`__)
- Piotr Bialecki (`ptrblck <https://github.com/ptrblck>`__)
- Natalia Gimelshein (`ngimel <https://github.com/ngimel>`__)

Intel / MKLDNN
~~~~~~~~~~~~~~

Expand Down Expand Up @@ -182,8 +190,8 @@ C10 utils and operator dispatch
- Dmytro Dzhulgakov (`dzhulgakov <https://github.com/dzhulgakov>`__)
- (emeritus) Sebastian Messmer (`smessmer <https://github.com/smessmer>`__)

PyTorch -> ONNX
~~~~~~~~~~~~~~~
ONNX exporter
~~~~~~~~~~~~~
- Bowen Bao (`BowenBao <https://github.com/BowenBao>`__)
- Aaron Bockover (`abock <https://github.com/abock>`__)
- (emeritus) Gary Miguel (`garymm <https://github.com/garymm>`__)
Expand Down Expand Up @@ -221,6 +229,7 @@ Apple M1/MPS
- Alban Desmaison (`alband <https://github.com/alband>`__)
- Nikita Shulga (`malfet <https://github.com/malfet>`__)
- Kulin Seth (`kulinseth <https://github.com/kulinseth>`__)
- Ramin Azarmehr (`razarmehr <https://github.com/razarmehr>`__)

PowerPC
~~~~~~~
Expand Down

0 comments on commit 2c79b9c

Please sign in to comment.