Skip to content

Implement automatic tool list refresh using the SDK's toolListChanged… #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
sandros06 wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Implement automatic tool list refresh using the SDK's toolListChanged… #1

sandros06 wants to merge 3 commits into from
+90 −12

Conversation

@sandros06
Copy link
Owner

@sandros06 sandros06 commented Nov 8, 2025 •
edited
Loading

Candidate (not clean) branch for this implemntation SDK

brave_B7b59tDHrs

@cliffhall cliffhall mentioned this pull request Nov 21, 2025
Open
cliffhall
cliffhall suggested changes Dec 25, 2025
View reviewed changes
Copy link

@cliffhall cliffhall left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems partially baked. I don't see how the tool list changed handler will ever be called.

Also, It would be good to fully explain the changes in the description of your PR.

Woops. Just noticing this is on your personal fork.

@sandros06
Copy link
Owner Author

sandros06 commented Dec 25, 2025 •
edited
Loading

This seems partially baked. I don't see how the tool list changed handler will ever be called.

Also, It would be good to fully explain the changes in the description of your PR.

Woops. Just noticing this is on your personal fork.

Hey @cliffhall

modelcontextprotocol/typescript-sdk#1206

We need to reimplement this since it was merged. Do you know which version of the TypeScript SDK includes it?

Edit: It's now live in 1.25.0

And currently on main, we have ^1.24.3, so it's will be ok ?

Alexandre Chavenon added 2 commits December 25, 2025 20:16
Implement automatic tool list refresh using the SDK's toolListChanged…
776a4e6 
…Options by chipgpt:feature/tool-list-change-notification-handler
chore(mcp): adapt to tools list changes introduced in SDK v1.25.0+
62289e4 
Updated implementation to align with the new tools list change behavior
introduced in @modelcontextprotocol/sdk v1.25.0 and later.

See: modelcontextprotocol/typescript-sdk#1206
@sandros06 sandros06 force-pushed the feature/tool-list-change-notification-handler branch from 1894079 to 62289e4 Compare December 25, 2025 19:52
@sandros06 sandros06 changed the base branch from main to main2 December 25, 2025 19:59
@sandros06 sandros06 changed the base branch from main2 to main December 25, 2025 19:59
@sandros06
Copy link
Owner Author

sandros06 commented Dec 25, 2025

@cliffhall

brave_B7b59tDHrs

I’ve fixed and updated the branch to align with the SDK v1.25.0 changes.

The implementation has been rebased and cleaned up, and now only includes the relevant commits related to the tool list change handling.

Do you think this branch would be a good candidate to propose as a PR against inspector’s main branch?

Thanks for taking a look!

@sandros06 sandros06 requested a review from cliffhall December 25, 2025 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cliffhall cliffhall Awaiting requested review from cliffhall

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sandros06 @cliffhall