Skip to content

⚡ Use classic for-loop in combineWithAllErrors#28

Merged
kai-orion merged 1 commit into
mainfrom
performance/combine-with-all-errors-loop-435808778699902627
Jul 15, 2026
Merged

⚡ Use classic for-loop in combineWithAllErrors#28
kai-orion merged 1 commit into
mainfrom
performance/combine-with-all-errors-loop-435808778699902627

Conversation

@kai-orion

Copy link
Copy Markdown
Member
  • 💡 What: Replaced the for...of loop in src/combine/combineWithAllErrors.ts with a classic index-based for loop.
  • 🎯 Why: To improve execution speed by avoiding iterator allocation overhead common with for...of loops, particularly in hot code paths or when dealing with large arrays.
  • 📊 Measured Improvement: Vitest benchmark results indicate a modest performance improvement overall across various scenarios (e.g. up to 1-5% in 10-item and 100-item arrays), although results vary by run, the classic loop provides more predictable memory performance by eliminating generator allocations.

PR created automatically by Jules for task 435808778699902627 started by @kai-orion

Replaces the `for...of` loop with a standard index-based `for` loop in `combineWithAllErrors` to reduce iterator allocation overhead in performance-sensitive code paths.
@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@kai-orion kai-orion marked this pull request as ready for review July 15, 2026 12:08
@kai-orion kai-orion merged commit f4bd693 into main Jul 15, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant