separate server/client port args for 'add' cmd #43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--portmeans very different things for theadd servervsadd clientcommand, especially when potentially combined with--outbound. Made them separate sub-arguments (instead of shared viaaddcommand) to allow for clearer help messages.Also fixed incorrect behavior of
--portfor theadd servercommand now that default has been changed to sync with--endpointwhere appropriate.Made the port explicit in added server config files to make it clear that servers always have a relay listening port, and what it is. This will also make it easier to figure out how to connect new servers to existing servers by inspecting existing config files.