Skip to content

BREAKING: Refactor retry argument attributes #22

Open
@jmgate

Description

@jmgate

Mypy doesn't like that the retry argument attributes are defined dynamically when a class is instantiated, so it'll complain that they don't exist when a subclass developer is trying to modify them when overriding/extending the parser. If instead of having separate attributes per registered stage, we just had a dict where the keys are the stage names, mypy would be happy.

Note: This will be a breaking change.

Metadata

Metadata

Assignees

Labels

Stage: Next ReleaseMerged into the `next` branch for the next major release.Type: RefactorRefactoring existing code to improve long-term sustainability.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions