Nick/fortran ordering #373
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…emory layout: * Only required fixing mttkrp and double
* Assumes core ordering is correct
* Ensure fortran order for data returned but not index arrays
* Doesn't return arrays so minimal changes needed?
* Mostly calls the ops from its parts
* See if anything blows up
Draft
dmdunla
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Try to resolve our fortran ambiguities. Everything is internally fortran and returns fortran ordered numpy arrays (potentially overly pessimistic but more consistent).
Resolves: #368 there's a moderate amount of discussion on that issue for context
Branches #367
📚 Documentation preview 📚: https://pyttb--373.org.readthedocs.build/en/373/