Fwdsim patches #517
Merged
Fwdsim patches #517
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
December 16, 2024 20:41
Changes the default behavior of casting with the 'auto' keyword to use the map forward simulator. Update germ selection to automatically convert to a matrix forward simulator as needed.
Fix tests that were broken by the switch to using map as the default forward simulator. Either update tests to support map natively, or for ones that rely on matrix make sure that is the simulator being used.
Remove a few unit tests that made reference or relied on an old model method that no longer exists. These tests were already being skipped (or had the sections referencing this old method commented out), so this doesn't actually affect anything other than making stuff cleaner.
rileyjmurray
added a commit
that referenced
this pull request
Dec 17, 2024
sserita
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a set of patches related to #496, which was just merged in.
Substantive changes:
ForwardSimulatorhas been updated so that the 'auto' keyword argument now defaults to theMapForwardSimulatorin all cases (previously this was only true for qudit models or for two-or-more qubits).MatrixForwardSimulatorif needed.Unit Test Fixes
test_packageswhich were written assuming the default simulator wasMatrixForwardSimulator. A whole bunch more broke for this reasone when I made the patch above changing the default casting behavior. Where appropriate I've updated these tests to be compatible with both simulators. In places where theMatrixForwardSimulatorreally was required (e.g.dproductandhproductmethods were required for the thing being tested) I've made sure those tests have had the proper simulator specified explicitly.Modelmethod which no longer exists. I went ahead and deleted these for the sake of cleaning things up. These tests were already being skipped or commented out, so there is no change to the tests being run.