Skip to content

Conversation

@jacobagilbert
Copy link

This resolves two issues building on OSX:

  1. OSX uses <machine/endian.h> instead of <endian.h>, and while a conditional include could be done with preprocessor directives (or passing CFLAGS="$CFLAGS -I~/usr/include/machine conditionally in CMake), using <sys/types.h> (which is cross platform) seems easier.
  2. Stops relying on template argument deduction for std::min and std::max calls. Or maybe you would prefer to cast these to the same type... if so i can update to that behavior, let me know. Either way whats in here fails on OSX.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant