Skip to content

save_model fix for factor value order#148

Merged
whart222 merged 9 commits intomainfrom
uai
Feb 5, 2026
Merged

save_model fix for factor value order#148
whart222 merged 9 commits intomainfrom
uai

Conversation

@mseyden
Copy link

@mseyden mseyden commented Jan 29, 2026

No description provided.

@codecov
Copy link

codecov bot commented Jan 29, 2026

Codecov Report

❌ Patch coverage is 94.59459% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.77%. Comparing base (7d56f66) to head (76ad07f).
⚠️ Report is 10 commits behind head on main.

Files with missing lines Patch % Lines
conin/common/conin/save_model.py 83.33% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #148      +/-   ##
==========================================
+ Coverage   82.61%   82.77%   +0.15%     
==========================================
  Files         100      100              
  Lines        6102     6135      +33     
  Branches      620      623       +3     
==========================================
+ Hits         5041     5078      +37     
+ Misses        925      920       -5     
- Partials      136      137       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@whart222
Copy link
Collaborator

whart222 commented Feb 3, 2026

Per our discussion yesterday, I'd like to add tests that confirm this PR on a simple example. We have UAI writer tests, but apparently they were insufficient.

@whart222 whart222 merged commit a29b19b into main Feb 5, 2026
11 checks passed
@whart222 whart222 deleted the uai branch February 5, 2026 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants