Add SCC Reader support for configurable framerate#510
Open
powelli wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #509
It's been noted that using SCC files with non-standard framerates (i.e. those other than 29.97 NDF & 29.97 DF) is questionable practice and easily leads to confusion as there's no direct metadata embedded in the files indicating when this is the case, the original SCC implementation was an encoding of the data from CTA 608 data stream developed for NTSC broadcast at 29.97 fps.
However these files/workflows do occasionally exist in the real world. This change adds support for ingesting these files to enable them to be accurately converted to other formats, but stops short of extending the SCC output with additional non-standard framerates to discourage further use.