Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Content not associated with a region is not pruned from ISD before deciding if it's empty #19

Closed
nigelmegitt opened this issue Dec 4, 2023 · 2 comments · Fixed by #25
Assignees

Comments

@nigelmegitt
Copy link

Right now, the imsc-hrm-tests dur003-fail passes when it should fail. See also w3c/imsc-hrm-tests#9.

It used to fail in imscHRM because the previous ISD beginning at 2.5s was considered non-empty, and therefore made the available time for the following ISD beginning at 3s be 0.5s. However, that previous ISD only contained content not associated with any region, and should therefore have been pruned. If it had been pruned, then the ISD should have been considered empty, and therefore the ISD beginning at 3s would have had a full 1s to render, and that older variant of the test should have passed instead of failing.

@palemieux palemieux self-assigned this Dec 4, 2023
@palemieux
Copy link
Contributor

palemieux commented Dec 4, 2023

The unit test fixture will not catch an expected-to-fail test that, in fact, does not fail the HRM:

ev = EventHandler()

@palemieux
Copy link
Contributor

However, that previous ISD only contained content not associated with any region, and should therefore have been pruned.

Even though it is pruned, so it still generates an ISD, which, because the region background is showAlways, triggers a background clear and region paint.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants