Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tolerance to DUR and NGBS checks #11

Closed
palemieux opened this issue Jul 13, 2023 · 0 comments · Fixed by #13
Closed

Add tolerance to DUR and NGBS checks #11

palemieux opened this issue Jul 13, 2023 · 0 comments · Fixed by #13

Comments

@palemieux
Copy link
Contributor

The render time and glyph cache checks do not tolerate any numerical errors:

imscHRM/src/main/python/imschrm/hrm.py

Line 118 in e8f6d0a

if stats.dur > avail_render_time:

@palemieux palemieux mentioned this issue Jul 13, 2023
Merged
palemieux added a commit that referenced this issue Jul 13, 2023
@palemieux
* Fix incorrect glyph cache invalidation on empty ISDs (#12)
23130f7 
* Add optional tolerances on glyph cache and render time comparisons (#11)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

* Fix incorrect glyph cache invalidation on empty ISDs sandflow/imscHRM
1 participant
@palemieux