Localize short names for black and white #714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lykahb
commented
Sep 26, 2024
| "Потягніть для вибору області інтересу. Виберіть одну точку для" | ||
| "скасування області." | ||
| "Потягніть для вибору області інтересу. Виберіть одну точку для скасування " | ||
| "області." |
There was a problem hiding this comment.
In the past PR #712 I formatted this file manually rather than used the i18n.py script. So there would be many unrelated changes in this file.
| msgstr "Ч" | ||
|
|
||
| msgid "short color W" | ||
| msgstr "Б" |
There was a problem hiding this comment.
The new messages for the graph and stats.
| @@ -765,8 +771,8 @@ msgstr "KataGo" | |||
|
|
|||
| msgid "aihelp:default" | |||
| msgstr "" | |||
| "Full strength KataGo AI. Strength is affected by 'max visits' and 'model' " | |||
| "in the general settings 'engine' section and engine configuration file. No " | |||
There was a problem hiding this comment.
The i18n.py reformatted it.
lykahb
commented
Sep 26, 2024
| @@ -499,7 +499,7 @@ | |||
| StatsLabel: | |||
| id: pointloss_label | |||
| label: i18n._('stats:pointslost') if root.points_lost is None or root.points_lost > 0 else i18n._('stats:pointsgained') | |||
| text: '{}: {:.1f}'.format(root.player,abs(root.points_lost)) if root.points_lost is not None else '...' | |||
| text: '{}: {:.1f}'.format(i18n._(f'short color {root.player}'), abs(root.points_lost)) if root.points_lost is not None else '...' | |||
There was a problem hiding this comment.
That's more logic than most of the UI elements have. I considered extracting this into Python and passing points_delta_label & points_delta but decided to keep the scope more focused.
lykahb
force-pushed
the
lykahb/localize-black-white
branch
from
5e3e923 to
f06f626
Compare
lykahb
force-pushed
the
lykahb/localize-black-white
branch
from
f06f626 to
04709d4
Compare
lykahb
commented
Sep 27, 2024
| @@ -39,10 +39,10 @@ KaTrain is a tool for analyzing games and playing go with AI feedback from KataG | |||
| <a href="http://github.com/sanderland/katrain/blob/master/README.md"><img alt="English" src="https://github.com/sanderland/katrain/blob/master/katrain/img/flags/flag-uk.png" width=50></a> | |||
| <a href="http://translate.google.com/translate?sl=en&tl=de&u=https%3A%2F%2Fgithub.com%2Fsanderland%2Fkatrain%2Fblob%2Fmaster%2FREADME.md"><img alt="German" src="https://github.com/sanderland/katrain/blob/master/katrain/img/flags/flag-de.png" width=50></a> | |||
| <a href="http://translate.google.com/translate?sl=en&tl=fr&u=https%3A%2F%2Fgithub.com%2Fsanderland%2Fkatrain%2Fblob%2Fmaster%2FREADME.md"><img alt="French" src="https://github.com/sanderland/katrain/blob/master/katrain/img/flags/flag-fr.png" width=50></a> | |||
| <a href="http://translate.google.com/translate?sl=en&tl=uk&u=https%3A%2F%2Fgithub.com%2Fsanderland%2Fkatrain%2Fblob%2Fmaster%2FREADME.md"><img alt="Ukrainian" src="https://github.com/sanderland/katrain/blob/master/katrain/img/flags/flag-ua.png" width=50></a> | |||
There was a problem hiding this comment.
I missed the list of localizations in the previous PR. Added it in the same order as in the UI.
|
Thanks. Will pass this by the community for any local conventions. Edit: consensus is 🚀 |
sanderland
approved these changes
Sep 28, 2024
|
Is this a wrong way to show the localized color names in the "Player Setup" menu?
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces the B&W in the graph and the stats box. I took a liberty to update the other languages. Luckily, all supported languages have the colors begin with the different letters.