LF CLCK source cleanup #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good code wise... But maybe there should be a note in the readme that the clock menu option has been removed for all but the generic? It may prevent some issues in the future. |
|
Merging as is... Will include a note in the next release about the change to the LF CLCK changes. |
|
@dlabun thanks for merging. Adding a note to the read me is a great idea! As it was released part of the 0.2.0 release. |
|
@sandeepmistry A changelog may be in order at this point, what do you think? |
|
@dlabun agreed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This sets the LF CLK source for all variants except the generic variants. I've only left the menu items for generic boards, if someone wants to tests an alternative LF CLK source for a non-generic board, they should just use the generic variant instead - as this keeps the boards.txt cleaner.
@dlabun please review, after this is merged, we can finally make a new v0.3.0 release.