Skip to content

Remove '\\.\', closes #245 #247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 24, 2018
Merged

Remove '\\.\', closes #245 #247

merged 2 commits into from
Feb 24, 2018

Conversation

probonopd
Copy link
Contributor

This fixes the \\.\/dev/ttyACM0: No such file or directory error on Linux.

@probonopd probonopd mentioned this pull request Feb 17, 2018
Closed
@dlabun dlabun requested a review from sandeepmistry February 18, 2018 17:29
@mristau
Copy link

mristau commented Feb 19, 2018 •
edited
Loading

According to BlackMagic Repo Readme, the \\.\ should be used on Windows with COM-Ports higher than 10

Note: On Mac OS X use the /dev/cu.usbmodem. Don't use the tty version of this device as this one will freeze gdb when it tries to open it.
On Windows, use the the COM port instead of /dev/ttyACM0. For ports >= COM10, add the prefix \\.\, for example:

target extended-remote COM3
target extended-remote \\.\COM10

https://github.com/blacksphere/blackmagic/wiki/Getting-Started

@probonopd
Copy link
Contributor Author

While \\.\ should be used on Windows with COM-Ports higher than 10, the \\.\ entirely prevents this from working from anything but Windows. No other core uses the \\.\ Windows workaround.

Please merge my pull request. The documentation states that \\.\ needs to be used on Windows with COM-Ports higher than 10. But it should not be the default.

@dlabun dlabun requested review from dlabun and removed request for sandeepmistry February 21, 2018 20:13
sandeepmistry
sandeepmistry reviewed Feb 22, 2018
View reviewed changes
platform.txt
@@ -140,16 +140,20 @@ tools.blackmagicprobe.upload.speed=230400

tools.blackmagicprobe.erase.params.verbose=
tools.blackmagicprobe.erase.params.quiet=-q --batch-silent
tools.blackmagicprobe.erase.pattern="{path}{cmd}" -quiet -ex "target extended-remote \\.\{serial.port}" -ex "monitor swdp_scan" -ex "attach 1" -ex "monitor erase mass" -ex "echo \nErase finished!\n" -ex "detach" -ex "quit"
tools.blackmagicprobe.erase.pattern="{path}{cmd}" -quiet -ex "target extended-remote {serial.port}" -ex "monitor swdp_scan" -ex "attach 1" -ex "monitor erase mass" -ex "echo \nErase finished!\n" -ex "detach" -ex "quit"
tools.blackmagicprobe.erase.pattern.windows="{path}{cmd}" -quiet -ex "target extended-remote \\.\{serial.port}" -ex "monitor swdp_scan" -ex "attach 1" -ex "monitor erase mass" -ex "echo \nErase finished!\n" -ex "detach" -ex "quit"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we get a single pattern going if @micooke's idea from #245 (comment) also works on Linux and Mac

It would be easy to maintain if both versions are the same.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry i meant to strike through that - if you read a bit further down the comment i found out that my idea didnt work. Hopefully @probonopd's update has the same affect.

@dlabun dlabun merged commit 8c40273 into sandeepmistry:master Feb 24, 2018
@probonopd probonopd deleted the patch-1 branch February 24, 2018 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sandeepmistry sandeepmistry sandeepmistry left review comments

@micooke micooke micooke left review comments

@dlabun dlabun dlabun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@probonopd @mristau @sandeepmistry @micooke @dlabun