Add PCA1000X variant PCA10001 #226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sandeepmistry Should the PCA10001 be broken out to a separate folder? |
|
@dlabun no I think it's ok, it's a sub-variant of PCA1000x. @oyooyo please see comment in #224 (comment) . Do you want us to merge this or PR #224, which has both changes? |
Closed
|
@sandeepmistry Oops, sorry for that - I actually intended to truly separate the changes in this PR and PR #224, but I guess I screwed up (I'm still severely struggling with mastering GIT and Github). I'll update both PRs later today to address the mentioned issues. |
|
No worries, i'm no Github expert... If you need to you can simply create a new PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a PCA1000X board variant called PCA10001, for the PCA10001 development board.