-
-
Notifications
You must be signed in to change notification settings - Fork 652
Make SPI port configurable at runtime #103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This is great, #104 asks about using multiple radios, this could assist with that. I'll try to give this a test this week. |
@@ -50,6 +50,8 @@ | |||
|
|||
#define MAX_PKT_LENGTH 255 | |||
|
|||
static SPIClass& SPIPORT = SPI; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not a member variable?
edit: I ask about the reason: programming, compiling, resources or design pattern?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed, in order to make this work with multiple SX1276 devices at the same time, this would need to be part of the class.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@morganrallen For multiple devices are not multiple spi bus required. So 1 spi will work with 4-7 devices.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh right, I even commented that on #104
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The important part is the interrupt of each device @morganrallen are u working on this now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not actively working on this yet, I hope to get time tomorrow or Saturday
@wero1414 @morganrallen I think a Let me comment on #104 regarding multiple radios. |
Closing in favour of #105. |
No description provided.