Skip to content

feat(skill): integrate kitup for bundled agent skill install - #88

Merged
samzong merged 1 commit into
mainfrom
feat/kitup-skill-install
Jun 30, 2026
Merged

feat(skill): integrate kitup for bundled agent skill install#88
samzong merged 1 commit into
mainfrom
feat/kitup-skill-install

Conversation

@samzong

@samzong samzong commented Jun 30, 2026

Copy link
Copy Markdown
Owner

What's changed?

  • Add gmc skill install via kitup's go-cobra adapter
  • Embed skills/gmc/SKILL.md into the binary with go:embed
  • Add install coverage in cmd/skill_test.go
  • Regenerate man pages for the new command surface

Why

  • Users should be able to install the bundled gmc Agent Skill into local coding agents with the same safe, conflict-aware workflow kitup provides elsewhere

Verification

  • make check

Wire kitup go-cobra adapter to ship the embedded gmc skill via
`gmc skill install`, with tests and regenerated man pages.
@samzong
samzong merged commit 47aac5c into main Jun 30, 2026
1 check passed
@samzong
samzong deleted the feat/kitup-skill-install branch June 30, 2026 14:16

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 571874be5f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread cmd/skill.go
Comment on lines +12 to +17
skillCmd := kitupcobra.NewSkillCommand(kitupcobra.Options{
AppID: "gmc",
Bundle: kitup.FSBundle(skills.GMC, "gmc"),
DefaultScope: kitup.UserScope,
StdinTTY: stdinTTY(),
})

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Reject positional args for skill install

Because the kitup Cobra adapter used here constructs the install subcommand without an Args validator, Cobra accepts and ignores any positional arguments. For example, gmc skill install codex --yes treats codex as an unused extra arg rather than the target agent; with --yes it falls back to auto-detected agents and can write to different or multiple skill directories. Please wrap the returned command or set the install subcommand to cobra.NoArgs before registering it.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant