feat(skill): integrate kitup for bundled agent skill install - #88
Conversation
Wire kitup go-cobra adapter to ship the embedded gmc skill via `gmc skill install`, with tests and regenerated man pages.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 571874be5f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| skillCmd := kitupcobra.NewSkillCommand(kitupcobra.Options{ | ||
| AppID: "gmc", | ||
| Bundle: kitup.FSBundle(skills.GMC, "gmc"), | ||
| DefaultScope: kitup.UserScope, | ||
| StdinTTY: stdinTTY(), | ||
| }) |
There was a problem hiding this comment.
Reject positional args for skill install
Because the kitup Cobra adapter used here constructs the install subcommand without an Args validator, Cobra accepts and ignores any positional arguments. For example, gmc skill install codex --yes treats codex as an unused extra arg rather than the target agent; with --yes it falls back to auto-detected agents and can write to different or multiple skill directories. Please wrap the returned command or set the install subcommand to cobra.NoArgs before registering it.
Useful? React with 👍 / 👎.
What's changed?
gmc skill installvia kitup's go-cobra adapterskills/gmc/SKILL.mdinto the binary withgo:embedcmd/skill_test.goWhy
Verification
make check