Corrects the sharing of predicates between date_created and created_at.

[bwatson78]

Summary

Corrects the sharing of predicates between date_created and created_at.

Type of change (for release notes)

• notes-valkyrie Valkyrie Progress

@samvera/hyrax-code-reviewers

[github-actions]

Test Results

    17 files  +  1      17 suites  +1   2h 17m 33s ⏱️ + 11m 55s
 6 705 tests +139   6 408 ✅ +141  297 💤  - 1  0 ❌  - 1 
13 178 runs  +979  12 783 ✅ +972  395 💤 +8  0 ❌  - 1 

Results for commit 9c3be46. ± Comparison against base commit 4b74958.

This pull request removes 257 and adds 396 tests. Note that renamed tests count towards both.

spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007f1740e23ac0>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007f727a70c300>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007f1740e2c800>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007f727fa45c88>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy AdminSet: 4be5877a-4614-4181-b9c1-8e456d6466d6
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy Hyrax::AdministrativeSet: 87b5a23b-f0e4-4c3d-8f71-ac8a60add89d
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit AdminSet: 3458d59b-b8a7-49bf-8062-b6e4066dac67
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit Hyrax::AdministrativeSet: 051a8d99-ce8a-4d79-af28-6386cd98f239
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to update AdminSet: cf1fc3df-a2a3-4259-945d-d73a34fb51b5
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to update Hyrax::AdministrativeSet: d4783baa-1c4b-496c-8732-34a7f0fa6335
…

spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007f96a1b28ad8>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007fa4cc8d1cd8>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007f96a26dcaa0>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007fa4d4925c90>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy AdminSet: 52f21314-94b6-4405-9a32-7c023d39816f
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy Hyrax::AdministrativeSet: ee6dcc60-f2e4-4fab-af1d-39cda90907d6
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit AdminSet: 0834f576-900c-4f25-831f-6c5fd479efdb
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit Hyrax::AdministrativeSet: a3bd7ae0-d396-4263-af1e-d6a266c17bf9
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to update AdminSet: 0dcedd29-ebbb-40ca-b8aa-9565c283c8b0
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to update Hyrax::AdministrativeSet: 75d06bd3-f5d4-4c38-89ba-898a88db597c
…

♻️ This comment has been updated with latest results.

[orangewolf]

@bwatson78 code seems good there. My question to you is what kind of change is it? If you have existing records, does changing this predicate break things? Specifically if I have data in created at and then change the predicate, what happens the next time I open that record? Do we need a data migration of some sort here?