Skip to content

Update Gemfile for bundler 2.5 #6570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 3, 2024
Merged

Update Gemfile for bundler 2.5 #6570

merged 1 commit into from
Jan 3, 2024

Conversation

dlpierce
Copy link
Member

@dlpierce dlpierce commented Jan 3, 2024

Changes in bundler 2.5 prevent multiple gemspec calls from taking effect. We now assume the application Gemfile will correctly load the hyrax gemspec file using the RAILS_ROOT env var.

Fixes

Mission inclusion of certain gems in the engine Gemfile.lock, manifested as missing rspec in CI.

@samvera/hyrax-code-reviewers

Changes in bundler 2.5 prevent multiple gemspec calls from taking effect. We now assume the application Gemfile will correctly load the hyrax gemspec file using the RAILS_ROOT env var.
@dlpierce dlpierce added the notes-bugfix Release Notes: Fixed a bug label Jan 3, 2024
@dlpierce dlpierce requested a review from bwatson78 January 3, 2024 19:33
@bwatson78 bwatson78 merged commit 48d62fd into main Jan 3, 2024
@bwatson78 bwatson78 deleted the fix-bundler-2.5 branch January 3, 2024 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
notes-bugfix Release Notes: Fixed a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants